Listen on printing shortcut to open print view for printing #544

susnux · 2023-02-10T16:24:37Z

📝 Summary

Resolves: Improve printing layout #542
Resolves: Printing: Collective title always on blank first page #543

Listen on CTRL + P (or CMD respectivly), then cancel printing the collective but open the print view to the correct styling get applied.
Moreover I changed the target name of the new tab / window, so the printing view gets recycled for all printing tasks to not spam the users tabs.

🖼️ Screenshots

🏚️ Before	🏡 After

🏁 Checklist

Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
Sign-off message is added to all commits
Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
Documentation (README or documentation) has been updated or is not required

cypress · 2023-02-10T16:48:15Z

Passing run #983 ↗︎

0	76	0	0	0

Details:

Listen on printing shortcut to open print view for printing
Project: Collectives	Commit: `50d77bcbb2`
Status: Passed	Duration: 03:58 💡
Started: Jul 28, 2023 5:03 PM	Ended: Jul 28, 2023 5:07 PM

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

max-nextcloud

Looks good to me. Just one minor fix to prevent overwriting other keyboard shortcuts.

(Have not tried it - just from the sourcecode it seems ctrl+shift+P migth also be affected.)

src/views/CollectiveView.vue

mejo-

Thanks @susnux! This would make it impossible to print single pages though, no? Or am I missing something?

src/components/Collective/CollectiveActions.vue

src/views/CollectiveView.vue

mejo- · 2023-02-14T09:41:31Z

Thanks @susnux! This would make it impossible to print single pages though, no? Or am I missing something?

@susnux what's your take on the question of printing a single page?

src/store/store.js

susnux · 2023-02-15T12:04:52Z

🤦 I did not noticed that you currently print the whole collective with subpages...

The idea was to not duplicate places with printing specific styling. So forward to the export view, I am currently thinking about resolving this by adding a property to the print view to only print the current page, do you think this is a acceptable solution?

mejo- · 2023-02-15T13:05:12Z

The idea was to not duplicate places with printing specific styling. So forward to the export view, I am currently thinking about resolving this by adding a property to the print view to only print the current page, do you think this is a acceptable solution?

Yeah, in the long run I would like to add a dedicated export view that allows to print or export pages to PDF. The default should be to export the whole collective, but it should be possible to (un)select specific pages. Unfortunately this is not very high on the priority list. See #463.

Your intermediate solution to allow printing only a specific page in the print view sounds good to me!

susnux · 2023-04-16T16:28:19Z

I am currently try to work on this again, I think the best way to solve this is to add subpage support for the export view as well. But this will require quite some work on that view (as I am not that into the collectives app structure). I hope to get this working this month :)

susnux · 2023-04-18T15:02:02Z

It is now possible to use the print view to only print subpages, this is now also used for CTRL+P and there is a print menu entry in the pages action menu.

susnux · 2023-06-26T20:37:38Z

@mejo- Any idea why only one cypress ci was successfully?

* Listen on printing shortcut to open print view for printing * Hide toastify dialogs when printing * Make sure background is removed Signed-off-by: Ferdinand Thiessen <[email protected]>

susnux · 2023-07-28T17:13:50Z

@mejo- Any idea why only one cypress ci was successfully?

Never mind CI is green after rebasing 🎉

pjrobertson · 2023-08-08T10:27:58Z

The images in the initial PR post look like this also solves the problem of the content being moved on to the 2nd page when it's longer than 1 page (no page break). I find that every collective I try to print longer than a specific amount has this issue - the title on the first page and content on the 2nd page. Hopefully this can be merged soon!

mejo- · 2023-08-08T11:24:18Z

src/components/Collective/CollectiveActions.vue

@@ -142,6 +142,7 @@ export default {
 			'isCollectiveAdmin',
 			'isPublic',
 			'loading',
+			'printLink',


This seems like a leftover, printLink() is defined as computed property below and not available as getter from the store.

mejo-

I gave this a quick test. Unfortunately I ran into several issues:

It doesn't work for first-level pages because they somehow get a double slash in the URL.
It doesn't work for second-level pages (and first-level pages with the double slash removed). Console error is: this.currentPage is undefined.

mejo- · 2023-08-08T11:24:38Z

src/components/Collective/CollectiveActions.vue

@@ -166,6 +167,10 @@ export default {
 				? generateUrl(`/apps/collectives/p/${this.shareTokenParam}/print/${this.collective.name}`)
 				: generateUrl(`/apps/collectives/_/print/${this.collective.name}`)
 		},
+
+		unshareIcon() {


Seems like a leftover or copy/paste error as well. unshareIcon() is not used here.

mejo- · 2023-08-08T11:26:32Z

src/store/pages.js

@@ -171,6 +171,14 @@ export default {
 			return state.pages.find(p => (p.parentId === parentId && p.title === TEMPLATE_PAGE))
 		},

+		pagePrintLink: (state, get) => (page) => {
+			const path = [page.collectivePath.split('/').at(-1), page.filePath.split('/'), page.fileName]
+			if (path.at(-1) === 'Readme.md') path.splice(-1, 1)


We don't use these one-line if () ... syntax so far, I'd prefer to stick to if () { \n ... \n }` 😬

Same for the following two lines.

mejo- · 2023-08-08T11:28:16Z

src/views/CollectiveView.vue

+		printKeyHandler(event) {
+			// Handle `CTRL+P` or `CMD+P` but ensure ALT or SHIFT are NOT pressed (e.g. CTRL+SHIFT+P is new private tab on firefox)
+			if ((event.metaKey || event.ctrlKey) && event.key.toLowerCase() === 'p' && !(event.altKey || event.shiftKey)) {
+				if (!this.currentPage) return


mejo- · 2023-08-08T11:38:20Z

src/router.js

@@ -37,11 +37,13 @@ const routes = [
 		path: '/_/print/:collective',
 		component: CollectivePrintView,
 		props: (route) => route.params,
+		children: [{ path: ':page*' }],


Can you give me a quick hint what you want to achieve here? Maybe I oversaw something, but I don't see where this would be used 🤔

Also resolves the problem with empty page before first page content on Firefox. Fixes: #544 Fixes: #542 Signed-off-by: Jonas <[email protected]>

mejo- · 2023-10-30T15:13:29Z

Closing this PR now that we have fixes from #971.

susnux added enhancement New feature or request 3. to review labels Feb 10, 2023

susnux requested review from azul and mejo- February 10, 2023 16:24

susnux requested a review from max-nextcloud February 10, 2023 17:07

max-nextcloud requested changes Feb 10, 2023

View reviewed changes

src/views/CollectiveView.vue Outdated Show resolved Hide resolved

susnux force-pushed the fix/printing-background branch from 57d0d68 to 58bd7f6 Compare February 10, 2023 17:26

susnux requested a review from max-nextcloud February 10, 2023 17:27

susnux force-pushed the fix/printing-background branch from 58bd7f6 to 4d171cb Compare February 10, 2023 18:03

max-nextcloud mentioned this pull request Feb 10, 2023

fix: Prevent empty additional pages added when printing #545

Merged

4 tasks

susnux force-pushed the fix/printing-background branch 2 times, most recently from 42312e9 to 14541e2 Compare February 13, 2023 09:37

mejo- requested changes Feb 13, 2023

View reviewed changes

src/components/Collective/CollectiveActions.vue Show resolved Hide resolved

src/views/CollectiveView.vue Outdated Show resolved Hide resolved

susnux force-pushed the fix/printing-background branch 2 times, most recently from 0fce9d0 to ff789f4 Compare February 13, 2023 14:01

mejo- requested changes Feb 14, 2023

View reviewed changes

src/store/store.js Outdated Show resolved Hide resolved

susnux force-pushed the fix/printing-background branch from ff789f4 to bb18d7c Compare April 16, 2023 13:52

susnux requested a review from mejo- April 18, 2023 14:52

susnux force-pushed the fix/printing-background branch 2 times, most recently from bb18d7c to 1c04476 Compare April 18, 2023 15:00

susnux force-pushed the fix/printing-background branch 2 times, most recently from de87d59 to b60cd65 Compare April 18, 2023 15:22

susnux force-pushed the fix/printing-background branch 2 times, most recently from 9aa720a to afbc924 Compare June 26, 2023 16:17

feat: Allow to export or print single pages or pages with subpages

50d77bc

* Listen on printing shortcut to open print view for printing * Hide toastify dialogs when printing * Make sure background is removed Signed-off-by: Ferdinand Thiessen <[email protected]>

susnux force-pushed the fix/printing-background branch from afbc924 to 50d77bc Compare July 28, 2023 17:00

mejo- reviewed Aug 8, 2023

View reviewed changes

mejo- requested changes Aug 8, 2023

View reviewed changes

mejo- reviewed Aug 8, 2023

View reviewed changes

mejo- added a commit that referenced this pull request Oct 27, 2023

fix(css): Fix CSS to print full page without border and background

35507f3

Also resolves the problem with empty page before first page content on Firefox. Fixes: #544 Fixes: #542 Signed-off-by: Jonas <[email protected]>

mejo- added a commit that referenced this pull request Oct 27, 2023

fix(css): Fix CSS to print full page without border and background

9aee1af

Also resolves the problem with empty page before first page content on Firefox. Fixes: #544 Fixes: #542 Signed-off-by: Jonas <[email protected]>

mejo- mentioned this pull request Oct 27, 2023

Printing fixes #971

Merged

4 tasks

mejo- closed this Oct 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Listen on printing shortcut to open print view for printing #544

Listen on printing shortcut to open print view for printing #544

susnux commented Feb 10, 2023

cypress bot commented Feb 10, 2023 •

edited

Loading

max-nextcloud left a comment

mejo- left a comment

mejo- commented Feb 14, 2023

susnux commented Feb 15, 2023

mejo- commented Feb 15, 2023

susnux commented Apr 16, 2023

susnux commented Apr 18, 2023

susnux commented Jun 26, 2023

susnux commented Jul 28, 2023

pjrobertson commented Aug 8, 2023

mejo- Aug 8, 2023

mejo- left a comment

mejo- Aug 8, 2023

mejo- Aug 8, 2023

mejo- Aug 8, 2023

mejo- Aug 8, 2023

mejo- commented Oct 30, 2023

Listen on printing shortcut to open print view for printing #544

Listen on printing shortcut to open print view for printing #544

Conversation

susnux commented Feb 10, 2023

📝 Summary

🖼️ Screenshots

🏁 Checklist

cypress bot commented Feb 10, 2023 • edited Loading

Passing run #983 ↗︎

max-nextcloud left a comment

Choose a reason for hiding this comment

mejo- left a comment

Choose a reason for hiding this comment

mejo- commented Feb 14, 2023

susnux commented Feb 15, 2023

mejo- commented Feb 15, 2023

susnux commented Apr 16, 2023

susnux commented Apr 18, 2023

susnux commented Jun 26, 2023

susnux commented Jul 28, 2023

pjrobertson commented Aug 8, 2023

mejo- Aug 8, 2023

Choose a reason for hiding this comment

mejo- left a comment

Choose a reason for hiding this comment

mejo- Aug 8, 2023

Choose a reason for hiding this comment

mejo- Aug 8, 2023

Choose a reason for hiding this comment

mejo- Aug 8, 2023

Choose a reason for hiding this comment

mejo- Aug 8, 2023

Choose a reason for hiding this comment

mejo- commented Oct 30, 2023

cypress bot commented Feb 10, 2023 •

edited

Loading